Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LinkPlugin] Allows pasting email links from clipboard #2444

Merged
merged 3 commits into from
Jun 27, 2023
Merged

[LinkPlugin] Allows pasting email links from clipboard #2444

merged 3 commits into from
Jun 27, 2023

Conversation

dimaanj
Copy link
Collaborator

@dimaanj dimaanj commented Jun 26, 2023 •
edited
Loading

Summary

This PR allows pasting email links from clipboard.

Before

email-link-before.mp4

After

email-link-after.mp4

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 79aaa18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 76 packages
Name Type
@udecode/utils Patch
@udecode/plate-common Patch
@udecode/plate-core Patch
@udecode/plate-utils Patch
@udecode/slate-react Patch
@udecode/slate-utils Patch
@udecode/slate Patch
@udecode/plate-button Patch
@udecode/plate-cloud Patch
@udecode/plate-comments Patch
@udecode/plate-find-replace Patch
@udecode/plate-dnd Patch
@udecode/plate-autoformat Patch
@udecode/plate-break Patch
@udecode/plate-combobox Patch
@udecode/plate-node-id Patch
@udecode/plate-normalizers Patch
@udecode/plate-reset-node Patch
@udecode/plate-select Patch
@udecode/plate-tabbable Patch
@udecode/plate-trailing-block Patch
@udecode/plate-floating Patch
@udecode/plate-headless Patch
@udecode/plate-media Patch
@udecode/plate-alignment Patch
@udecode/plate-basic-elements Patch
@udecode/plate-basic-marks Patch
@udecode/plate-block-quote Patch
@udecode/plate-code-block Patch
@udecode/plate-emoji Patch
@udecode/plate-font Patch
@udecode/plate-heading Patch
@udecode/plate-highlight Patch
@udecode/plate-horizontal-rule Patch
@udecode/plate-indent-list Patch
@udecode/plate-indent Patch
@udecode/plate-kbd Patch
@udecode/plate-line-height Patch
@udecode/plate-link Patch
@udecode/plate-list Patch
@udecode/plate-mention Patch
@udecode/plate-paragraph Patch
@udecode/plate-table Patch
@udecode/resizable Patch
@udecode/plate-selection Patch
@udecode/plate-serializer-csv Patch
@udecode/plate-serializer-docx Patch
@udecode/plate-serializer-html Patch
@udecode/plate-juice Patch
@udecode/plate-serializer-md Patch
@udecode/plate-suggestion Patch
@udecode/plate-ui-button Patch
@udecode/plate-ui-cloud Patch
@udecode/plate-ui-combobox Patch
@udecode/plate-ui-comments Patch
@udecode/plate-ui-cursor Patch
@udecode/plate-ui-dnd Patch
@udecode/plate-ui-find-replace Patch
@udecode/plate-ui-alignment Patch
@udecode/plate-ui-block-quote Patch
@udecode/plate-ui-code-block Patch
@udecode/plate-ui-emoji Patch
@udecode/plate-ui-excalidraw Patch
@udecode/plate-ui-font Patch
@udecode/plate-ui-horizontal-rule Patch
@udecode/plate-ui-line-height Patch
@udecode/plate-ui-link Patch
@udecode/plate-ui-list Patch
@udecode/plate-ui-media Patch
@udecode/plate-ui-mention Patch
@udecode/plate-ui-table Patch
@udecode/plate-ui-placeholder Patch
@udecode/plate-styled-components Patch
@udecode/plate-ui-toolbar Patch
@udecode/plate Patch
@udecode/plate-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ❌ Failed (Inspect) Jun 27, 2023 10:29am
plate-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 10:29am
plate-udecode ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 10:29am

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 26, 2023

AI-Generated Summary: This pull request updates the LinkPlugin to allow pasting email links. The changes involve updating isUrl.ts to include support for email links by adding a regular expression emailLintRE for matching these links and modifying the isUrl function. Additionally, corresponding tests have been added to isUrl.spec.ts to ensure proper functionality of the newly added support for email links. In total, 13 insertions were made and 1 deletion was performed across 2 files.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 26, 2023

Thank you @dimaanj for this first contribution!

@reviewpad reviewpad bot added the small Pull request is small label Jun 26, 2023
@ghost
Copy link

ghost commented Jun 26, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@vercel vercel bot temporarily deployed to Preview – plate-examples June 26, 2023 12:44 Inactive
@vercel vercel bot temporarily deployed to Preview – plate-udecode June 26, 2023 12:45 Inactive
@vercel vercel bot temporarily deployed to Preview – plate June 26, 2023 12:45 Inactive
@vercel vercel bot temporarily deployed to Preview – plate-examples June 27, 2023 08:45 Inactive
@vercel vercel bot temporarily deployed to Preview – plate June 27, 2023 08:46 Inactive
@vercel vercel bot temporarily deployed to Preview – plate-udecode June 27, 2023 08:47 Inactive
@zbeyens zbeyens marked this pull request as ready for review June 27, 2023 10:16
@zbeyens zbeyens merged commit 8d0c872 into udecode:main Jun 27, 2023
@vercel vercel bot temporarily deployed to Preview – plate June 27, 2023 10:19 Inactive
@vercel vercel bot temporarily deployed to Preview – plate-udecode June 27, 2023 10:20 Inactive
@vercel vercel bot temporarily deployed to Preview – plate-examples June 27, 2023 10:29 Inactive
@zbeyens zbeyens mentioned this pull request Jun 27, 2023
Merged
@espipj espipj mentioned this pull request May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimaanj @zbeyens